Skip to content

aws: use byo hosted zone in sharednetwork workflow#17062

Closed
staebler wants to merge 1 commit intoopenshift:masterfrom
staebler:byo_hosted_zone
Closed

aws: use byo hosted zone in sharednetwork workflow#17062
staebler wants to merge 1 commit intoopenshift:masterfrom
staebler:byo_hosted_zone

Conversation

@staebler
Copy link
Copy Markdown
Contributor

@staebler staebler commented Mar 23, 2021

Use a bring-your-own hosted zone in the AWS sharednetwork workflow. The hosted zone will be created in the pre steps and deleted in the post steps.

https://issues.redhat.com/browse/CORS-1667

@staebler
Copy link
Copy Markdown
Contributor Author

staebler commented Mar 23, 2021

/hold for openshift/installer#4772

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 23, 2021
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Mar 23, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: staebler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 23, 2021
@staebler staebler force-pushed the byo_hosted_zone branch 4 times, most recently from aadde6a to 3f88b33 Compare March 23, 2021 18:11
@staebler
Copy link
Copy Markdown
Contributor Author

staebler commented Mar 24, 2021

/test pj-rehearse

@staebler staebler force-pushed the byo_hosted_zone branch 6 times, most recently from fc7ac27 to f52081f Compare March 25, 2021 15:40
@staebler
aws: use byo hosted zone in sharednetwork workflow
67bf999 
Use a bring-your-own hosted zone in the AWS sharednetwork workflow.
The hosted zone will be created in the pre steps and deleted in the
post steps.

https://issues.redhat.com/browse/CORS-1667
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Mar 25, 2021

@staebler: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/rehearse/openshift/installer/master/e2e-aws-shared-vpc 67bf999 link /test pj-rehearse
ci/prow/pj-rehearse 67bf999 link /test pj-rehearse

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@staebler
Copy link
Copy Markdown
Contributor Author

staebler commented Mar 25, 2021

The hosted zone is created in ipi-conf-aws-sharednetwork.

Using vpc_id: vpc-0da6db2598758bfa8
Using hosted zone: Z08300302W90PGBCGXY95

The hosted zone is deleted in ipi-deprovision-aws-sharednetwork,

Deleting hosted zone: Z08300302W90PGBCGXY95
{
    "ChangeInfo": {
        "Id": "/change/C06402751X1P3MRDL3DB8",
        "Status": "PENDING",
        "SubmittedAt": "2021-03-25T18:38:23.667000+00:00"
    }
}

The install is failing, as expected, because the installer needs openshift/installer#4772 first to know what to do with the user-supplied hosted zone.

level=error msg=Error: error creating Route53 Hosted Zone: ConflictingDomainExists: The VPC vpc-0da6db2598758bfa8 in region us-west-2 has already been associated with the hosted zone Z08300302W90PGBCGXY95 with the same domain name.
level=error msg=	status code: 400, request id: 8cacc47f-07d5-40ab-8198-da894255c226
level=error
level=error msg=  on ../tmp/openshift-install-857617221/route53/base.tf line 18, in resource "aws_route53_zone" "int":
level=error msg=  18: resource "aws_route53_zone" "int" {

@staebler staebler mentioned this pull request May 17, 2021
Merged
@staebler
Copy link
Copy Markdown
Contributor Author

staebler commented Jun 14, 2021

/hold for openshift/installer#4772

Installer PR merged. Lifting hold.
/hold cancel

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 14, 2021
@staebler
Copy link
Copy Markdown
Contributor Author

staebler commented Jun 16, 2021

Superseded by #19310.

@staebler
Copy link
Copy Markdown
Contributor Author

staebler commented Jun 16, 2021

/close

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 16, 2021

@staebler: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 16, 2021
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 16, 2021

@staebler: Closed this PR.

Details

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot closed this Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ewolinetz ewolinetz Awaiting requested review from ewolinetz

@vrutkovs vrutkovs Awaiting requested review from vrutkovs

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@staebler @openshift-ci-robot